-
Couldn't load subscription status.
- Fork 812
Update claims mapping policy instructions in documentation #1750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@lwojtanowski : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the documentation for configuring claims mapping policies to provide clearer instructions and prevent the AADSTS50146 error. The changes expand the step-by-step instructions for modifying the application manifest.
- Clarifies that the
acceptMappedClaimsattribute should be located under theapiobject - Adds an important note about setting properties in the root object for legacy AAD Graph App Manifest
- Updates step numbering to be more consistent
Comments suppressed due to low confidence (1)
docs/identity-platform/custom-extension-tokenissuancestart-configuration.md:229
- The JSON example shows
acceptMappedClaimsandrequestedAccessTokenVersionat the root level, but the instructions specify thatacceptMappedClaimsshould be under theapiobject. The example should be updated to reflect the correct structure or include both locations to match the instructions.
{
"id": "22222222-0000-0000-0000-000000000000",
"acceptMappedClaims": true,
"requestedAccessTokenVersion": 2,
...
}
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Learn Build status updates of commit 7154513:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/identity-platform/custom-extension-tokenissuancestart-configuration.md | Details |
docs/identity-platform/custom-extension-tokenissuancestart-configuration.md
- Line 233, Column 202: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/entra/identity-platform/reference-microsoft-graph-app-manifest' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. - Line 233, Column 202: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/entra/identity-platform/reference-microsoft-graph-app-manifest' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
Reason:
Explaining the manifest modification process. Expanding the instructions will help avoid the AADSTS50146 error.