Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing pages for the deprecated marketplace listings #125645

Closed
wants to merge 5 commits into from

Conversation

sdubeymsft
Copy link
Contributor

The marketplace listings referenced on the docs are deprecated and removed. Removing the relevant documentation.

…vm.md

This program is now deprecated and the artifacts mentioned in the article are being removed from the marketplace. Deleting the file to remove the article as well.
Copy link
Contributor

@sdubeymsft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 52de259:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/azure-government/documentation-government-impact-level-5.md ⚠️Warning Details
articles/azure-government/documentation-government-stig-linux-vm.md ✅Succeeded n/a (file deleted or renamed)
articles/azure-government/documentation-government-stig-windows-vm.md ✅Succeeded n/a (file deleted or renamed)
articles/azure-government/index.yml ✅Succeeded
articles/azure-government/TOC.yml ✅Succeeded

articles/azure-government/documentation-government-impact-level-5.md

  • Line 422, Column 3: [Warning: file-not-found - See documentation] Invalid file link: './documentation-government-stig-linux-vm.md'.
  • Line 423, Column 3: [Warning: file-not-found - See documentation] Invalid file link: './documentation-government-stig-windows-vm.md'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@v-dirichards
Copy link
Contributor

@sdubeymsft Did you intend to make these deletions in the private repo? Deleted files should also get redirects. Leaving this open in case @EliotSeattle wants to chime in.


@EliotSeattle

Can you review the proposed changes? You may want to pull these changes into the private repo and make sure to add redirects for the deleted articles.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Jan 30, 2025
Copy link
Contributor

@EliotSeattle EliotSeattle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdubeymsft

We need to provide a redirect URL for people who try to get to these URLs (by bookmark, say). Do you have existing page(s) that would be appropriate to move people to? Either you or I can take care of those additions to the \azure-docs-pr-eliotgra.openpublishing.redirection.government.json file. I think it's just these two, right?

articles/azure-government/documentation-government-stig-linux-vm.md
articles/azure-government/documentation-government-stig-windows-vm.md

@v-dirichards I've never pulled from azure-docs to the azure-docs-pr repo. Sounds like a lot might go wrong if I tried. ;-) Is that something that you could do? I agree that, unless there's an objection on unusual grounds from @sdubeymsft that we'd want to delete these files and pull in the ToC changes in the private repo as well.

Thanks,
Eliot

Copy link
Contributor

Learn Build status updates of commit dc0da0a:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-government/documentation-government-impact-level-5.md ✅Succeeded
articles/azure-government/documentation-government-stig-linux-vm.md ✅Succeeded n/a (file deleted or renamed)
articles/azure-government/documentation-government-stig-windows-vm.md ✅Succeeded n/a (file deleted or renamed)
articles/azure-government/index.yml ✅Succeeded
articles/azure-government/TOC.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Deleted File(s) This PR deletes Markdown or YAML files owned by another author, or json file(s). The pull request must contain a comment from the pull request author confirming that all the file deletions are intentional before the pull request can be merged.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

@sdubeymsft
Copy link
Contributor Author

@EliotSeattle Thank you for your help. Yes, we can use "https://learn.microsoft.com/en-us/azure/automation/automation-dsc-configuration-based-on-stig" as redirect for both of the deleted pages? I didn't find the file you mentioned at that location in azure-docs repo? Yes, these are the only two files. Yes, changes apply to private repo as well. Let me know if you would like me to create a separate PR in private repo. Thank you.

@ttorble
Copy link
Contributor

ttorble commented Jan 31, 2025

@sdubeymsft

We need to provide a redirect URL for people who try to get to these URLs (by bookmark, say). Do you have existing page(s) that would be appropriate to move people to? Either you or I can take care of those additions to the \azure-docs-pr-eliotgra.openpublishing.redirection.government.json file. I think it's just these two, right?

articles/azure-government/documentation-government-stig-linux-vm.md articles/azure-government/documentation-government-stig-windows-vm.md

@v-dirichards I've never pulled from azure-docs to the azure-docs-pr repo. Sounds like a lot might go wrong if I tried. ;-) Is that something that you could do? I agree that, unless there's an objection on unusual grounds from @sdubeymsft that we'd want to delete these files and pull in the ToC changes in the private repo as well.

Thanks, Eliot

@EliotSeattle

The PR in the private repo will need to contain the appropriate redirects for it to pass validation. In this case, rather than us pulling partial content across, it would be best that you or @sdubeymsft close this PR and create a new PR directly in the private repo, which you can sign off when ready. Thanks

@sdubeymsft
Copy link
Contributor Author

@EliotSeattle- I don't see the pages I am removing in the azure-docs-pr at all.

@EliotSeattle
Copy link
Contributor

Thanks, @sdubeymsft

@ttorble is right. Let's abandon this PR. Please close this. I'll go ahead and make the changes in azure-docs-pr (including the redirect) and we can adhere to the correct process. This is an easy content change that's become more complicated than it should.

@v-dirichards
Copy link
Contributor

Thanks, @sdubeymsft

@ttorble is right. Let's abandon this PR. Please close this. I'll go ahead and make the changes in azure-docs-pr (including the redirect) and we can adhere to the correct process. This is an easy content change that's become more complicated than it should.

#please-close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants