Skip to content

editorial changes to Linux pages #3505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dbradish-microsoft merged 4 commits into from
Feb 17, 2023
Merged

editorial changes to Linux pages #3505

dbradish-microsoft merged 4 commits into from
Feb 17, 2023

Conversation

@ChaseCrum
Copy link
Contributor

@ChaseCrum ChaseCrum commented Feb 2, 2023

Made editorial changes for Linux based pages

@ChaseCrum ChaseCrum requested review from jiasli and removed request for jiasli February 2, 2023 21:33
@learn-build-service-prod
Copy link
Contributor

learn-build-service-prod bot commented Feb 2, 2023

Learn Build status updates of commit b35b1b8:

⚠️ Validation status: warnings

File Status Preview URL Details
docs-ref-conceptual/includes/cli-install-linux-apt.md ⚠️Warning View Details
docs-ref-conceptual/includes/cli-install-linux-dnf.md 💡Suggestion View Details
docs-ref-conceptual/includes/cli-install-linux-script.md ✅Succeeded View
docs-ref-conceptual/includes/rpm-warning.md ✅Succeeded View

docs-ref-conceptual/includes/cli-install-linux-apt.md

  • Line 99, Column 93: [Warning: bookmark-not-found] Cannot find bookmark '#set-release' in 'docs-ref-conceptual/includes/cli-install-linux-apt.md'.
  • Line 105, Column 1: [Warning: bookmark-not-found] Cannot find bookmark '#set-release' in 'docs-ref-conceptual/includes/cli-install-linux-apt.md'.
  • Line 111, Column 54: [Warning: bookmark-not-found] Cannot find bookmark '#set-release' in 'docs-ref-conceptual/includes/cli-install-linux-apt.md'.

docs-ref-conceptual/includes/cli-install-linux-dnf.md

  • Line 17, Column 27: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/cli/azure/install-azure-cli-linux?pivots=script' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@ChaseCrum ChaseCrum marked this pull request as ready for review February 6, 2023 20:18
dbradish-microsoft
dbradish-microsoft approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@dbradish-microsoft dbradish-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiasli, I am fine with the gramatical changes. Please review for technical accuracy.

@yonzhan yonzhan requested a review from bebound February 13, 2023 23:29
bebound
bebound reviewed Feb 14, 2023
View reviewed changes
@dbradish-microsoft
Copy link
Collaborator

dbradish-microsoft commented Feb 17, 2023

I am merging this PR with sufficient time left for the Engineering team review.

@learn-build-service-prod
Copy link
Contributor

learn-build-service-prod bot commented Feb 17, 2023

Learn Build status updates of commit 14cf678:

⚠️ Validation status: warnings

File Status Preview URL Details
docs-ref-conceptual/includes/cli-install-linux-apt.md ⚠️Warning View Details
docs-ref-conceptual/includes/cli-install-linux-dnf.md 💡Suggestion View Details
docs-ref-conceptual/includes/cli-install-linux-script.md ✅Succeeded View
docs-ref-conceptual/includes/rpm-warning.md ✅Succeeded View

docs-ref-conceptual/includes/cli-install-linux-apt.md

  • Line 99, Column 93: [Warning: bookmark-not-found] Cannot find bookmark '#set-release' in 'docs-ref-conceptual/includes/cli-install-linux-apt.md'.
  • Line 105, Column 1: [Warning: bookmark-not-found] Cannot find bookmark '#set-release' in 'docs-ref-conceptual/includes/cli-install-linux-apt.md'.
  • Line 111, Column 54: [Warning: bookmark-not-found] Cannot find bookmark '#set-release' in 'docs-ref-conceptual/includes/cli-install-linux-apt.md'.

docs-ref-conceptual/includes/cli-install-linux-dnf.md

  • Line 17, Column 27: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/cli/azure/install-azure-cli-linux?pivots=script' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@dbradish-microsoft dbradish-microsoft merged commit a16f92f into MicrosoftDocs:main Feb 17, 2023
@bebound
Copy link
Contributor

bebound commented Feb 28, 2023 •
edited
Loading

This PR removes <div id="set-release"/> and causes this warning

Line 99, Column 93: [Warning: bookmark-not-found] Cannot find bookmark '#set-release' in 'docs-ref-conceptual/includes/cli-install-linux-apt.md'.
Line 105, Column 1: [Warning: bookmark-not-found] Cannot find bookmark '#set-release' in 'docs-ref-conceptual/includes/cli-install-linux-apt.md'.
Line 111, Column 54: [Warning: bookmark-not-found] Cannot find bookmark '#set-release' in 'docs-ref-conceptual/includes/cli-install-linux-apt.md'.

@ChaseCrum Could you please fix this?

bebound added a commit to bebound/azure-docs-cli that referenced this pull request Mar 2, 2023
@bebound
Revert MicrosoftDocs#3505
bba4547
@bebound bebound mentioned this pull request Mar 2, 2023
Merged
dbradish-microsoft pushed a commit that referenced this pull request Mar 9, 2023
@bebound
Arm64 package is available (#3522)
f4f28e1 
* Init

* Add note

* Revert #3505

* Only provides arm64 package for apt dnf tdnf

* Minor fix
@jiasli jiasli mentioned this pull request Aug 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bebound bebound bebound left review comments

@dbradish-microsoft dbradish-microsoft dbradish-microsoft approved these changes

@jiasli jiasli Awaiting requested review from jiasli

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChaseCrum @dbradish-microsoft @bebound