Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarity edits for jenkins RA #420

Merged
merged 4 commits into from
Feb 26, 2018
Merged

clarity edits for jenkins RA #420

merged 4 commits into from
Feb 26, 2018

Conversation

bennage
Copy link
Contributor

@bennage bennage commented Feb 21, 2018

I'm not confident in how to word this.
I'm under the impression that there a single service principal that used by all of the agents.
Does the master use the service principal?

@bennage
Copy link
Contributor Author

bennage commented Feb 21, 2018

✅ Validation status: passed

File Status Preview URL Details
docs/reference-architectures/jenkins/index.md ✅Succeeded View

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@bennage
Copy link
Contributor Author

bennage commented Feb 21, 2018

✅ Validation status: passed

File Status Preview URL Details
docs/reference-architectures/jenkins/index.md ✅Succeeded View

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@lbrader
Copy link

lbrader commented Feb 21, 2018

The Master can be assigned a SP. Each Agent in the pipeline can also be setup with it's own SP to help separate different resources for security reasons. Also this brings in the questions of how many Key - Vaults do you want to support in your pipeline. 1 or many.

@bennage
Copy link
Contributor Author

bennage commented Feb 21, 2018

I just discussed this with PC. She was okay with the change.

@bennage
Copy link
Contributor Author

bennage commented Feb 22, 2018

✅ Validation status: passed

File Status Preview URL Details
docs/reference-architectures/jenkins/index.md ✅Succeeded View

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@bennage
Copy link
Contributor Author

bennage commented Feb 26, 2018

✅ Validation status: passed

File Status Preview URL Details
docs/reference-architectures/jenkins/index.md ✅Succeeded View

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@VeronicaWasson VeronicaWasson merged commit cc5d1fd into master Feb 26, 2018
@VeronicaWasson VeronicaWasson deleted the jenkins-security branch February 26, 2018 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants