Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing hard-coded locales from URLs #419

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Conversation

bennage
Copy link
Contributor

@bennage bennage commented Feb 20, 2018

These are causing problems for our localization process.

@bennage
Copy link
Contributor Author

bennage commented Feb 20, 2018

✅ Validation status: passed

File Status Preview URL Details
docs/antipatterns/chatty-io/index.md ✅Succeeded View
docs/aws-professional/index.md ✅Succeeded View
docs/aws-professional/services.md ✅Succeeded View
docs/best-practices/auto-scaling.md ✅Succeeded View
docs/best-practices/retry-service-specific.md ✅Succeeded View
docs/checklist/dev-ops.md ✅Succeeded View
docs/cloud-adoption-guide/adoption-intro/subscription-explainer.md ✅Succeeded View
docs/guide/architecture-styles/event-driven.md ✅Succeeded View
docs/patterns/cache-aside.md ✅Succeeded View
docs/patterns/retry.md ✅Succeeded View
docs/reference-architectures/sharepoint/index.md ✅Succeeded View
docs/reference-architectures/virtual-machines-windows/single-vm.md ✅Succeeded View
docs/resiliency/disaster-recovery-azure-applications.md ✅Succeeded View
docs/resources/diagrams.md ✅Succeeded View
docs/service-fabric/migrate-from-cloud-services.md ✅Succeeded View
docs/service-fabric/refactor-migrated-app.md ✅Succeeded View

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Copy link
Contributor

@alexbuckgit alexbuckgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good.

@bennage
Copy link
Contributor Author

bennage commented Feb 20, 2018

If we have 2/3 approvals, feel free to merge.

@Petertaylor9999
Copy link
Contributor

Looks good to me!

@Petertaylor9999 Petertaylor9999 merged commit 8365aae into master Feb 20, 2018
@bennage bennage deleted the locale-links branch February 22, 2018 17:19
ghost pushed a commit that referenced this pull request Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants