-
Notifications
You must be signed in to change notification settings - Fork 156
IObjectSerializer fix examples. #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IObjectSerializer fix examples. #534
Conversation
|
Docs Build status updates of commit 427faeb: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
|
Docs Build status updates of commit 1c48beb: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
docs/helpers/ObjectSerializer.md
Outdated
|
|
||
| ## Examples | ||
|
|
||
| ### Json.NET |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd why everything is replaced in the diff here... line endings?
We should keep the System.Text.Json example too (and it seems to have the proper object interface already). It's still prevalent and should still be the first we list. We should just have 3 examples in total, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd why everything is replaced in the diff here... line endings?
I did not base off of master and was missing .gitconfig
|
Docs Build status updates of commit 2348135: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Change exmaples to reflect the change in the interface. Serializes to and from objects instead of strings.
|
Docs Build status updates of commit 01c5946: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Change exmaples to reflect the change in the interface.
Serializes to and from objects instead of strings.
Fixes #497
Docs for Toolkit PR
CommunityToolkit/WindowsCommunityToolkit#3702
What changes to the docs does this PR provide?
Change exmaples to reflect the change in the interface.
Serializes to and from objects instead of strings.
PR Checklist
Please check if your PR fulfills the following requirements:
devfor new features,masterfor typos/improvements)Other information