Skip to content

Conversation

@Rosuavio
Copy link
Contributor

@Rosuavio Rosuavio commented Jun 9, 2021

Change exmaples to reflect the change in the interface.
Serializes to and from objects instead of strings.

Fixes #497

Docs for Toolkit PR

CommunityToolkit/WindowsCommunityToolkit#3702

What changes to the docs does this PR provide?

Change exmaples to reflect the change in the interface.
Serializes to and from objects instead of strings.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Correctly picked the right branch to base the change off (dev for new features, master for typos/improvements)
  • For new pages, used the provided template
  • For new features, added an entry in the Table of Contents
  • Ran against a spell and grammar checker
  • Contains NO breaking changes

Other information

@opbld32
Copy link

opbld32 commented Jun 9, 2021

Docs Build status updates of commit 427faeb:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld33
Copy link

opbld33 commented Jun 9, 2021

Docs Build status updates of commit 1c48beb:

✅ Validation status: passed

File Status Preview URL Details
docs/helpers/ObjectSerializer.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:


## Examples

### Json.NET
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd why everything is replaced in the diff here... line endings?

We should keep the System.Text.Json example too (and it seems to have the proper object interface already). It's still prevalent and should still be the first we list. We should just have 3 examples in total, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd why everything is replaced in the diff here... line endings?

I did not base off of master and was missing .gitconfig

@opbld31
Copy link

opbld31 commented Jun 15, 2021

Docs Build status updates of commit 2348135:

✅ Validation status: passed

File Status Preview URL Details
docs/helpers/ObjectSerializer.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Change exmaples to reflect the change in the interface.
Serializes to and from objects instead of strings.
@opbld32
Copy link

opbld32 commented Jun 15, 2021

Docs Build status updates of commit 01c5946:

✅ Validation status: passed

File Status Preview URL Details
docs/helpers/ObjectSerializer.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@michael-hawker michael-hawker merged commit a70069e into MicrosoftDocs:master Jun 24, 2021
@Rosuavio Rosuavio deleted the iobser-str-to-obj branch June 24, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IObjectSerializer docs are outdated

6 participants