Skip to content

Conversation

@mrlacey
Copy link
Contributor

@mrlacey mrlacey commented Dec 5, 2020

Fixes #411

What changes to the docs does this PR provide?

Standardize inclusion of "XAML Control" and "Control" on page titles

Also fixes some typos and links using http rather than https

PR Checklist

Please check if your PR fulfills the following requirements:

  • Correctly picked the right branch to base the change off (master for new features, live for typos/improvements)
  • For new pages, used the provided template
  • For new features, added an entry in the Table of Contents
  • Ran against a spell and grammar checker
  • Contains NO breaking changes

Other information

Also fixes some typos and links

For MicrosoftDocs#411
@opbld31
Copy link

opbld31 commented Dec 5, 2020

Docs Build status updates of commit d818464:

✅ Validation status: passed

File Status Preview URL Details
docs/controls/AdaptiveGridView.md ✅Succeeded View
docs/controls/BladeView.md ✅Succeeded View
docs/controls/CameraPreview.md ✅Succeeded View
docs/controls/Carousel.md ✅Succeeded View
docs/controls/DataGrid.md ✅Succeeded View
docs/controls/DockPanel.md ✅Succeeded View
docs/controls/DropShadowPanel.md ✅Succeeded View
docs/controls/Expander.md ✅Succeeded View
docs/controls/Eyedropper.md ✅Succeeded View
docs/controls/GridSplitter.md ✅Succeeded View
docs/controls/HeaderedContentControl.md ✅Succeeded View
docs/controls/HeaderedItemsControl.md ✅Succeeded View
docs/controls/HeaderedTextBlock.md ✅Succeeded View
docs/controls/ImageCropper.md ✅Succeeded View
docs/controls/ImageEx.md ✅Succeeded View
docs/controls/InAppNotification.md ✅Succeeded View
docs/controls/InfiniteCanvas.md ✅Succeeded View
docs/controls/LayoutTransformControl.md ✅Succeeded View
docs/controls/Loading.md ✅Succeeded View
docs/controls/MarkdownTextBlock.md ✅Succeeded View
docs/controls/MasterDetailsView.md ✅Succeeded View
docs/controls/Menu.md ✅Succeeded View
docs/controls/OrbitView.md ✅Succeeded View
docs/controls/RadialGauge.md ✅Succeeded View
docs/controls/RadialProgressBar.md ✅Succeeded View
docs/controls/RangeSelector.md ✅Succeeded View
docs/controls/RemoteDevicePicker.md ✅Succeeded View
docs/controls/RotatorTile.md ✅Succeeded View
docs/controls/ScrollHeader.md ✅Succeeded View
docs/controls/StaggeredPanel.md ✅Succeeded View
docs/controls/TabView.md ✅Succeeded View
docs/controls/TextToolbar.md ✅Succeeded View
docs/controls/TileControl.md ✅Succeeded View
docs/controls/TokenizingTextBox.md ✅Succeeded View
docs/controls/UniformGrid.md ✅Succeeded View
docs/controls/WrapPanel.md ✅Succeeded View
docs/toc.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@Kyaa-dost Kyaa-dost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor spelling and grammar corrections. Overall, looks great 🚀

@opbld30
Copy link

opbld30 commented Jan 20, 2021

Docs Build status updates of commit 046e4db:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • Line 0, Column 0: [Error-git-clone-failed] Failure to clone the repository `https://github.com/Microsoft/templates.docs.msft#master`. This could be caused by an incorrect repository URL, please verify the URL on the Docs Portal (https://ops.microsoft.com). This could also be caused by not having the proper permission the repository, please confirm that the GitHub group/team that triggered the build has access to the repository.
  • Line 0, Column 0: [Error-git-clone-failed] Failure to clone the repository `https://github.com/Microsoft/templates.docs.msft#master`. This could be caused by an incorrect repository URL, please verify the URL on the Docs Portal (https://ops.microsoft.com). This could also be caused by not having the proper permission the repository, please confirm that the GitHub group/team that triggered the build has access to the repository.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld32
Copy link

opbld32 commented Jan 20, 2021

Docs Build status updates of commit ca7e6cd:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • Line 0, Column 0: [Error-git-clone-failed] Failure to clone the repository `https://github.com/Microsoft/templates.docs.msft#master`. This could be caused by an incorrect repository URL, please verify the URL on the Docs Portal (https://ops.microsoft.com). This could also be caused by not having the proper permission the repository, please confirm that the GitHub group/team that triggered the build has access to the repository.
  • Line 0, Column 0: [Error-git-clone-failed] Failure to clone the repository `https://github.com/Microsoft/templates.docs.msft#master`. This could be caused by an incorrect repository URL, please verify the URL on the Docs Portal (https://ops.microsoft.com). This could also be caused by not having the proper permission the repository, please confirm that the GitHub group/team that triggered the build has access to the repository.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@mrlacey mrlacey requested a review from Kyaa-dost January 20, 2021 20:16
@opbld31
Copy link

opbld31 commented Jan 20, 2021

Docs Build status updates of commit 36c6b24:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • Line 0, Column 0: [Error-git-clone-failed] Failure to clone the repository `https://github.com/Microsoft/templates.docs.msft#master`. This could be caused by an incorrect repository URL, please verify the URL on the Docs Portal (https://ops.microsoft.com). This could also be caused by not having the proper permission the repository, please confirm that the GitHub group/team that triggered the build has access to the repository.
  • Line 0, Column 0: [Error-git-clone-failed] Failure to clone the repository `https://github.com/Microsoft/templates.docs.msft#master`. This could be caused by an incorrect repository URL, please verify the URL on the Docs Portal (https://ops.microsoft.com). This could also be caused by not having the proper permission the repository, please confirm that the GitHub group/team that triggered the build has access to the repository.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

@Kyaa-dost Kyaa-dost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to 🚀 🚀

@Kyaa-dost
Copy link
Contributor

@mrlacey was there any changes done recently that are causing these conflicts? Wondering why we are seeing conflicts 🤔 Seeing here in #405 as well.

@mrlacey
Copy link
Contributor Author

mrlacey commented Feb 12, 2021

@mrlacey was there any changes done recently that are causing these conflicts? Wondering why we are seeing conflicts 🤔 Seeing here in #405 as well.

It's not something I'm aware of. All the links that might point to useful information to debug what's wrong are Microsoft internal :(
(I'm assuming it's not affecting all changes so it's not an SSO issue with the account the build runs under.)

@Kyaa-dost Kyaa-dost merged commit 8198a9b into MicrosoftDocs:live Feb 25, 2021
@michael-hawker
Copy link
Collaborator

Yeah, something happened here. All the changes were complete file overwrites, so it's killing the diff back to main.

I'll try and cherry-pick this one back to main after, but since it doesn't look like it did proper line diffs, I'm not sure if that's going to work?

FYI @mrlacey @Kyaa-dost

@michael-hawker
Copy link
Collaborator

This may have been what caused #468? @nschonni does this seem like a suspect?

@nschonni
Copy link
Contributor

Yeah, if you look at https://github.com/MicrosoftDocs/WindowsCommunityToolkitDocs/pull/412/files?diff=unified&w=1 you can see it's the actual number/lines changed ignoring the line ending and whitespace diffs

michael-hawker pushed a commit that referenced this pull request Mar 11, 2021
Standardize titles
# Conflicts:
#	docs/controls/AdaptiveGridView.md
#	docs/controls/BladeView.md
#	docs/controls/CameraPreview.md
#	docs/controls/Carousel.md
#	docs/controls/DockPanel.md
#	docs/controls/DropShadowPanel.md
#	docs/controls/Expander.md
#	docs/controls/Eyedropper.md
#	docs/controls/GridSplitter.md
#	docs/controls/HeaderedContentControl.md
#	docs/controls/HeaderedItemsControl.md
#	docs/controls/HeaderedTextBlock.md
#	docs/controls/ImageCropper.md
#	docs/controls/ImageEx.md
#	docs/controls/InAppNotification.md
#	docs/controls/InfiniteCanvas.md
#	docs/controls/LayoutTransformControl.md
#	docs/controls/Loading.md
#	docs/controls/MarkdownTextBlock.md
#	docs/controls/MasterDetailsView.md
#	docs/controls/Menu.md
#	docs/controls/OrbitView.md
#	docs/controls/RadialGauge.md
#	docs/controls/RadialProgressBar.md
#	docs/controls/RangeSelector.md
#	docs/controls/RemoteDevicePicker.md
#	docs/controls/RotatorTile.md
#	docs/controls/ScrollHeader.md
#	docs/controls/StaggeredPanel.md
#	docs/controls/TabView.md
#	docs/controls/TextToolbar.md
#	docs/controls/TileControl.md
#	docs/controls/TokenizingTextBox.md
#	docs/controls/UniformGrid.md
#	docs/controls/WrapPanel.md
#	docs/toc.md
michael-hawker added a commit that referenced this pull request Mar 11, 2021
@mrlacey
Copy link
Contributor Author

mrlacey commented Mar 11, 2021

Don't know what happened here. Hoping that all the work and changes being made for the 7.0 release will mean that contributing docs changes/fixes/improvements/additions will be much easier in the future.

@mrlacey mrlacey deleted the i444-ControlPageTitles branch March 11, 2021 11:02
@michael-hawker
Copy link
Collaborator

@mrlacey yes, we're going to change our process around post 7.0 so everything just goes to master and we'll create a working branch for new features.

I think I was able to resolve everything in our final merge to update things for 7.0. There's just been a lot of other churn on the docs for other things, so it got messier than normal this time.

Part of our focus for 7.1 is improving the docs, like setting up a proper redirects file, so we'll go through and actually have a proper archive of all the docs that are no longer features we ship and can move other things to be better co-located for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent use of "Content" in titles

7 participants