-
Notifications
You must be signed in to change notification settings - Fork 156
Standardize titles #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize titles #412
Conversation
Also fixes some typos and links For MicrosoftDocs#411
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor spelling and grammar corrections. Overall, looks great 🚀
Co-authored-by: Kyaa Dost <[email protected]>
Co-authored-by: Kyaa Dost <[email protected]>
Co-authored-by: Kyaa Dost <[email protected]>
Co-authored-by: Kyaa Dost <[email protected]>
Co-authored-by: Kyaa Dost <[email protected]>
Co-authored-by: Kyaa Dost <[email protected]>
Co-authored-by: Kyaa Dost <[email protected]>
|
Docs Build status updates of commit 046e4db: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Co-authored-by: Kyaa Dost <[email protected]>
Co-authored-by: Kyaa Dost <[email protected]>
Co-authored-by: Kyaa Dost <[email protected]>
|
Docs Build status updates of commit ca7e6cd: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
|
Docs Build status updates of commit 36c6b24: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to 🚀 🚀
It's not something I'm aware of. All the links that might point to useful information to debug what's wrong are Microsoft internal :( |
|
Yeah, something happened here. All the changes were complete file overwrites, so it's killing the diff back to main. I'll try and cherry-pick this one back to main after, but since it doesn't look like it did proper line diffs, I'm not sure if that's going to work? FYI @mrlacey @Kyaa-dost |
|
Yeah, if you look at https://github.com/MicrosoftDocs/WindowsCommunityToolkitDocs/pull/412/files?diff=unified&w=1 you can see it's the actual number/lines changed ignoring the line ending and whitespace diffs |
Standardize titles # Conflicts: # docs/controls/AdaptiveGridView.md # docs/controls/BladeView.md # docs/controls/CameraPreview.md # docs/controls/Carousel.md # docs/controls/DockPanel.md # docs/controls/DropShadowPanel.md # docs/controls/Expander.md # docs/controls/Eyedropper.md # docs/controls/GridSplitter.md # docs/controls/HeaderedContentControl.md # docs/controls/HeaderedItemsControl.md # docs/controls/HeaderedTextBlock.md # docs/controls/ImageCropper.md # docs/controls/ImageEx.md # docs/controls/InAppNotification.md # docs/controls/InfiniteCanvas.md # docs/controls/LayoutTransformControl.md # docs/controls/Loading.md # docs/controls/MarkdownTextBlock.md # docs/controls/MasterDetailsView.md # docs/controls/Menu.md # docs/controls/OrbitView.md # docs/controls/RadialGauge.md # docs/controls/RadialProgressBar.md # docs/controls/RangeSelector.md # docs/controls/RemoteDevicePicker.md # docs/controls/RotatorTile.md # docs/controls/ScrollHeader.md # docs/controls/StaggeredPanel.md # docs/controls/TabView.md # docs/controls/TextToolbar.md # docs/controls/TileControl.md # docs/controls/TokenizingTextBox.md # docs/controls/UniformGrid.md # docs/controls/WrapPanel.md # docs/toc.md
|
Don't know what happened here. Hoping that all the work and changes being made for the 7.0 release will mean that contributing docs changes/fixes/improvements/additions will be much easier in the future. |
|
@mrlacey yes, we're going to change our process around post 7.0 so everything just goes to master and we'll create a working branch for new features. I think I was able to resolve everything in our final merge to update things for 7.0. There's just been a lot of other churn on the docs for other things, so it got messier than normal this time. Part of our focus for 7.1 is improving the docs, like setting up a proper redirects file, so we'll go through and actually have a proper archive of all the docs that are no longer features we ship and can move other things to be better co-located for instance. |
Fixes #411
What changes to the docs does this PR provide?
Standardize inclusion of "XAML Control" and "Control" on page titles
Also fixes some typos and links using http rather than https
PR Checklist
Please check if your PR fulfills the following requirements:
masterfor new features,livefor typos/improvements)Other information