Update to latest list #428
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgeurten
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Thanks for your help getting the Wizard templates in line with the published versions, @nathanmcnulty! There are parts of the published version that cannot be brough as-is into the Wizard so they will have to be removed
WDAC-Policy-Wizard/app/Resources/policyTemplates/Recommended_Driver_Blocklist.xml
Outdated
Show resolved
Hide resolved
WDAC-Policy-Wizard/app/Resources/policyTemplates/Recommended_Driver_Blocklist.xml
Outdated
Show resolved
Hide resolved
| @@ -2088,14 +4664,9 @@ | |||
| </Setting> | |||
| <Setting Provider="PolicyInfo" Key="Information" ValueName="Id"> | |||
| <Value> | |||
| <String>10.0.25210.0</String> | |||
There was a problem hiding this comment.
This needs to remail in the template
There was a problem hiding this comment.
Line 4667 had this:
10.0.27685.0
Does the version need to match 10.0.25210.0 for something with WDAC Wizard? If so, should on Line 3 also match the same?
Once I edit this last part for you, I'll see if I can figure out how to update the PR :p
WDAC-Policy-Wizard/app/Resources/policyTemplates/Recommended_Driver_Blocklist.xml
Outdated
Show resolved
Hide resolved
WDAC-Policy-Wizard/app/Resources/policyTemplates/Recommended_Driver_Blocklist.xml
Outdated
Show resolved
Hide resolved
nathanmcnulty
commented
Dec 13, 2024
| </Value> | ||
| </Setting> | ||
| <Setting Provider="PolicyInfo" Key="NoRevalidationUponRefresh" ValueName="NoRevalidationUponRefreshValue"> |
There was a problem hiding this comment.
Also looking at the diff, is this change OK, or should it be removed to match the previous?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From:
https://learn.microsoft.com/en-us/windows/security/application-security/application-control/app-control-for-business/design/microsoft-recommended-driver-block-rules#vulnerable-driver-blocklist-xml
https://aka.ms/VulnerableDriverBlockList