Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically infer local and remote path mappings for remote debugging #1385

Closed
DonJayamanne opened this issue Apr 12, 2018 · 8 comments
Closed

Automatically infer local and remote path mappings for remote debugging #1385

DonJayamanne opened this issue Apr 12, 2018 · 8 comments
Assignees
@d3r3kk
Labels
area-debugging feature-request Request for new features or functionality important Issue identified as high-priority
Milestone
2019, week 3 - Ja...

Comments

@DonJayamanne
Copy link

DonJayamanne commented Apr 12, 2018 •
edited
Loading

Currently we expect users to provide the local and remote path mappings when setting up remote debugging.
Then there's source references.

If we try to automatically infer local and remote path mappings, then source references might not work.
This issue is merely a reminder to look into the ability to automatically infer the path mappings.

microsoft/vscode#47914
@DonJayamanne
Copy link
Author

We'll need to come up with a solution for this before we release the new debugger, as the default values in launch.json will affect this.

@DonJayamanne DonJayamanne self-assigned this Apr 12, 2018
@DonJayamanne DonJayamanne added this to the April 2018 milestone Apr 12, 2018
@brettcannon brettcannon added the feature-request Request for new features or functionality label Apr 16, 2018
@DonJayamanne DonJayamanne modified the milestones: April 2018, May 2018 Apr 17, 2018
@brettcannon brettcannon modified the milestones: May 2018, June 2018 May 7, 2018
@brettcannon
Copy link
Member

If we can then great, otherwise "oh well" 😉

@brettcannon brettcannon removed this from the June 2018 milestone Jun 4, 2018
@DonJayamanne
Copy link
Author

Upstream issue microsoft/ptvsd#691

@echo-ray
Copy link

echo-ray commented Sep 5, 2018

That would be great!
(I`m current using remote-workspace)

@qubitron qubitron mentioned this issue Sep 27, 2018
Closed
4 tasks
@DonJayamanne DonJayamanne mentioned this issue Sep 27, 2018
Closed
@DonJayamanne
Copy link
Author

DonJayamanne commented Sep 28, 2018 •
edited
Loading

Solution - microsoft/ptvsd#691 (comment)

@DonJayamanne DonJayamanne mentioned this issue Oct 17, 2018
Closed
@DonJayamanne DonJayamanne added important Issue identified as high-priority needs PR labels Oct 17, 2018
@DonJayamanne DonJayamanne removed their assignment Dec 6, 2018
@DonJayamanne DonJayamanne mentioned this issue Dec 6, 2018
Closed
8 tasks
@d3r3kk d3r3kk self-assigned this Jan 9, 2019
d3r3kk added a commit to d3r3kk/vscode-python that referenced this issue Jan 9, 2019
@d3r3kk
Add localRoot & remoteRoot to the launch.json snippets
1f216a2 
For microsoft#1385

- Will set localRoot to "${workspaceFolder}" by default
- Will set remoteRoot to "." by default
- PTVSD will (eventually) pick this up and infer "." to be CWD.
@d3r3kk d3r3kk mentioned this issue Jan 9, 2019
Merged
6 tasks
@d3r3kk
Copy link

d3r3kk commented Jan 9, 2019

Here's my implementation in action:

1385_set_remote_local_paths_for_attach_launch

@d3r3kk d3r3kk removed this from the 2019, week 3 - Jan Sprint 2 milestone Jan 17, 2019
@DonJayamanne
Copy link
Author

Upstream dependency microsoft/ptvsd#1110

@DonJayamanne DonJayamanne assigned DonJayamanne and unassigned d3r3kk Jan 19, 2019
@DonJayamanne
Copy link
Author

DonJayamanne commented Jan 19, 2019 •
edited
Loading

@d3r3kk
@karthiknadig claims to have given you a branch to test the changes. Have we managed to test this?
If not, I can do that, then we can finish this item off.

@ghost ghost removed needs PR labels Jan 23, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@d3r3kk d3r3kk

Labels
area-debugging feature-request Request for new features or functionality important Issue identified as high-priority
Projects
None yet
Milestone
2019, week 3 - Jan Sprint 2
Development

No branches or pull requests
4 participants
@brettcannon @DonJayamanne @d3r3kk @echo-ray