-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTMLSelectElement.options #1558
Comments
Is there any special reason why this one-line fix keeps getting pushed back? https://github.com/Microsoft/TypeScript/blob/master/src/lib/dom.generated.d.ts#L6078 If it's just a matter of priorities I'd love to help out. This one is annoying me since there's no clean way to replace the interface property |
@zhengbli can you take a look. |
@robfe it's a prioritization thing. FWIW we're always accepting PRs for lib.d.ts fixes (or anything else that's very low-risk, e.g. wiki edits, comments / formatting improvements, etc). |
I've just noticed that IE 11 itself considers
In the older spec options is a
But as per http://www.w3.org/TR/html5/forms.html#dom-select-options it's an
where HTMLOptionsCollection is: interface HTMLOptionsCollection : HTMLCollection {
// inherits item()
attribute unsigned long length; // shadows inherited length
legacycaller HTMLOptionElement? (DOMString name);
setter creator void (unsigned long index, HTMLOptionElement? option);
void add((HTMLOptionElement or HTMLOptGroupElement) element, optional (HTMLElement or long)? before = null);
void remove(long index);
attribute long selectedIndex;
}; I'm keen to submit a fix for this, but what's your preference @mhegazy @RyanCavanaugh @zhengbli ?
|
Confirmed that in Edge the |
that does not help much. now the users who expect it to be |
@mhegazy tested on the latest Edge that |
👍 |
The text was updated successfully, but these errors were encountered: