Load assemblies into common appdomain/loadcontext #178
Conversation
|
Closing this out as there isn't any net benefit from making this specific change. |
|
It's required if you have any plans to support PowerShell Core. If no plans, then agree. |
|
Ah, right. I forgot to re-read #177 for the context reminder. I never did the investigation to verify that this change doesn't break PS4. Once verified, this can get merged in. Thanks Rafael. |
|
@riverar - I don't know how so much time passed on this, but I'm ready to get this merged-in. Ran into a problem with GitHub's web resolver UI, and it resolved a conflict in |
riverar
force-pushed
the
coreclr-alc-support
branch
from
f5a4927 to
f775a48
Compare
|
@HowardWolosky Rebased and ready to go. |
.NET Core implementation of `Assembly.Load` creates a new [AssemblyLoadContext](https://github.com/dotnet/coreclr/blob/master/Documentation/design-docs/assemblyloadcontext.md), isolating assemblies and ultimately resulting in dependency load related failures (e.g. microsoft#177). This change loads Azure Storage assemblies into the default AppDomain or AssemblyLoadContext via `Assembly.LoadFrom`.
riverar
force-pushed
the
coreclr-alc-support
branch
from
f775a48 to
0270635
Compare
|
(Edited commit msg to align with project's current state.) |
.NET Core implementation of
Assembly.Loadcreates a new AssemblyLoadContext, isolating assemblies and ultimately resulting in dependency load related failures (e.g. #177).This change loads telemetry and Azure Storage assemblies into the default AppDomain or AssemblyLoadContext via
Assembly.LoadFrom.