change publisher id and use production version of api #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kathryn Kodama <[email protected]>
patricktiu
reviewed
Oct 28, 2019
README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # VS Code MicroProfile Starter Extension | |||
|
|
|||
| This is a VS Code extension for the MicroProfile Starter (https://start.microprofile.io/). This extension makes use of the API https://test-start.microprofile.io/api/2. | |||
| A VS Code extension for the MicroProfile Starter (https://start.microprofile.io/). The MicroProfile Starter is a community effort by the MicroProfile community. This extension is hosted under the MicroShed organization. This extension makes use of the API https://start.microprofile.io/api/2. | |||
There was a problem hiding this comment.
I have a different suggestion to the description of the extension.
MicroProfile Starter extension provides support for generating MicroProfile Maven project with examples
based on the Eclipse MicroProfile Starter project (https://start.microprofile.io/) by the MicroProfile
community. You’ll be able to choose the version of MicroProfile and different specifications, such as of
CDI, Config, Health Check, Metrics, and more, for the generated example project.
Signed-off-by: Kathryn Kodama <[email protected]>
patricktiu
approved these changes
Oct 28, 2019
yeekangc
approved these changes
Oct 29, 2019
|
Looks good. Thank you, Kathryn & Patrick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kathryn Kodama [email protected]