Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates GitHub Actions #298

Merged
merged 34 commits into from
Nov 7, 2023
Merged

Updates GitHub Actions #298

merged 34 commits into from
Nov 7, 2023

Conversation

appiepollo14
Copy link
Collaborator

#297 Does this provide a solution for the first action checkbox? Tests for jaxrs and general are failing but could be fixed IMO.

@appiepollo14
Copy link
Collaborator Author

After updating to testcontainers 1.19.1 GitHub Actions runs succesfully without Podman installation steps because it runs priviliged by default. this updates also makes the Integration tests in General succeed. Leaves only the JAXRS tests failing.

@appiepollo14
Copy link
Collaborator Author

This remove testspace analytics upload. If wanted, please add back.

KyleAure
KyleAure requested changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@KyleAure KyleAure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is really close! Thanks for all the work you have done on this. Just some merge conflicts to resolve and one change request on my part :)

sample-apps/everything-app/Dockerfile Outdated Show resolved Hide resolved
@appiepollo14
Copy link
Collaborator Author

@KyleAure is this mergable?

@KyleAure KyleAure merged commit b712c1f into MicroShed:main Nov 7, 2023
5 of 6 checks passed
@appiepollo14 appiepollo14 deleted the fix/ga-ci branch November 7, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAure KyleAure KyleAure approved these changes

@aguibert aguibert Awaiting requested review from aguibert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@appiepollo14 @KyleAure