This repository has been archived by the owner on Oct 14, 2020. It is now read-only.
Dev/Release project support for maven #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awisniew90
force-pushed
the
release_proj
branch
from
8c88c76
to
f4df16b
Compare
chyt
approved these changes
Mar 15, 2019
chyt
reviewed
Mar 15, 2019
| } else { | ||
| throw new Exception( | ||
| "Unsupported packaging type - Liberty Boost currently supports WAR packaging type only."); | ||
| "No war files were found. The project must have a war pacakging type or specify war dependencies."); |
There was a problem hiding this comment.
Actually just noticed a typo here: pacakging
awisniew90
force-pushed
the
release_proj
branch
from
f4df16b
to
bdd1d21
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two main changes with this are: