Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Improve token handling, rename api key name, and write tests for Azure OpenAI #223

Merged
merged 7 commits into from
Aug 22, 2024
Merged

[Bug] Improve token handling, rename api key name, and write tests for Azure OpenAI #223

merged 7 commits into from
Aug 22, 2024

Conversation

JamesHWade
Copy link
Collaborator

@JamesHWade JamesHWade commented Aug 21, 2024 •
edited
Loading

Related issue

Description of changes

  • Use api_key instead of token for Azure OpenAI
  • Use cached token if available
  • Add tests for Azure OpenAI service

For contributors

  • I have added the relevant changes to the NEWS.md file
  • I have added relevant tests or documentation with my changes

For reviewers

  • Changes meet the acceptance criteria of the related issue
  • The contribution follows style conventions and code of conduct
  • Branch passes automated testing
  • I have incremented the package version in the DESCRIPTION file before merging

@JamesHWade
Copy link
Collaborator Author

Sorry to not wait on code review, but the azure openai code is currently broken. Want to get the fix out asap.

@JamesHWade JamesHWade merged commit 92397b1 into main Aug 22, 2024
8 checks passed
@calderonsamuel
Copy link
Collaborator

It's ok. Thanks for this work. Deleting the branch

@calderonsamuel calderonsamuel deleted the fix-azure-openai branch August 22, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calderonsamuel calderonsamuel Awaiting requested review from calderonsamuel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Azure_openai not running [Azure OpenAI] Error in : Not a GUID
2 participants
@JamesHWade @calderonsamuel