-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make interfaces depend only upon abstractions #14
base: master
Are you sure you want to change the base?
Conversation
Symbol is only available in EcmaScript6... do you have any idea if there is a way to compile it with backwards-compatibility? |
IE11 is the only everygreen browser not currently supporting native symbols (shame shame). Just add the following polyfill for IE11 support: |
Is there any chance you could fix the conflict with the latest code (I realised I hadn't chucked everything to github last time I pushed to npm) + add the polyfill? I'm rather stuck for time right now. |
Fixed the conflict and added the polyfill :) |
Added the optional getViewByName parameter to the handle function in IAmACommandHandler. Extracted IView to an interface too. |
Do you see any more merge errors on your side? |
When do you think you would be free to provide some feedback? |
Hello,
Using the iamacommandhandler interface currently depends on having a hard reference to DomainService and all of its dependencies. This pull request aims at making interfaces standalone for the DomainService by introducing an IDomainService, and interfaces for its dependencies. I've also added Symbols of the same name in each interface file, which allows inversifyjs injection during runtime, since typescript compiles away interfaces but keeps symbols.
Let me know if you feel this fits well with the project and I can write some tests to validate these new abstractions.
Thanks!