Try to handle egui color changes for old serialized session files#82
Merged
MichaelGrupp merged 3 commits intomasterfrom Jul 25, 2025
Merged
Try to handle egui color changes for old serialized session files#82MichaelGrupp merged 3 commits intomasterfrom
MichaelGrupp merged 3 commits intomasterfrom
Conversation
Without any conversion, an old saved value appears as a completely different color because it's assumed to be a gamma-premultiplied value (which it wasn't when serialized with egui < 0.32). This then lead e.g. the color picker to do wrong conversions and mess up the tint color. We now check if the session was written with the latest or an old version and fix the misinterpreted color values if needed. Note that while the values are correct after conversion, the image can still appear darker due to the blending changes in egui. Relates to: emilk/egui#5824 Relates to: emilk/egui#7311
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without any conversion, an old saved value appears as a completely different color because it's assumed to be a gamma-premultiplied value (which it wasn't when serialized with egui < 0.32). This then lead e.g. the color picker to do wrong conversions and mess up the tint color.
We now check if the session was written with the latest or an old version and fix the misinterpreted color values if needed.
Note that while the values are correct after conversion, the image can still appear darker due to the blending changes in egui.
Relates to: emilk/egui#5824
Relates to: emilk/egui#7311