-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Back Button at DetailActivity for Demo. #9
base: master
Are you sure you want to change the base?
Conversation
#proguard.config=${sdk.dir}/tools/proguard/proguard-android.txt:proguard-project.txt | ||
|
||
# Project target. | ||
target=android-15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't the target be 19?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change it and send PR again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichaelEvans I've set and pushed it again. Thanks. .
Looks good now, but I'd prefer to not merge PRs with merge commits. If you can fix that, I'll get merge it in :) |
@MichaelEvans Sorry I am a newbie and I don't get what you mean. You mean you want to squash the commits to the last commit ? |
No problem! If you look at the commits you've made here, one of them (yelinaung@0ddcae6) is a result of a merge commit (http://www.monarchdigital.com/blog/2013-02-08/merge-commits-and-how-prevent-them-git-rebase) You can probably just squash your commits down and add a message explaining what the two do together and that should solve the issue, but going forward that link should be helpful. |
I've added Back Button at DetailActivity for Demo. I just think it's easier. I also added the generated
project.properties
files. If you don't want it, I can remove and push again.Thanks.