Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Back Button at DetailActivity for Demo. #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yelinaung
Copy link

I've added Back Button at DetailActivity for Demo. I just think it's easier. I also added the generated project.properties files. If you don't want it, I can remove and push again.
Thanks.

#proguard.config=${sdk.dir}/tools/proguard/proguard-android.txt:proguard-project.txt

# Project target.
target=android-15
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the target be 19?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change it and send PR again.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelEvans I've set and pushed it again. Thanks. .

@MichaelEvans
Copy link
Owner

Looks good now, but I'd prefer to not merge PRs with merge commits. If you can fix that, I'll get merge it in :)

@yelinaung
Copy link
Author

@MichaelEvans Sorry I am a newbie and I don't get what you mean. You mean you want to squash the commits to the last commit ?

@MichaelEvans
Copy link
Owner

No problem! If you look at the commits you've made here, one of them (yelinaung@0ddcae6) is a result of a merge commit (http://www.monarchdigital.com/blog/2013-02-08/merge-commits-and-how-prevent-them-git-rebase) You can probably just squash your commits down and add a message explaining what the two do together and that should solve the issue, but going forward that link should be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants