fix template rendering with renamed secrets #726
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/templates/default.nix generates the placeholders manifest entry by using the name of the secret in the `sops.secrets` attrset. sops-install-secrets looked up the placeholder using the secret name and resolved to the wrong secret when a secret was renamed. This renames the entry in the manifest from `placeholderBySecretName` to `placeholderBySecretKey` and changes the lookup to use the key instead of the name. Fixes Mic92#688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modules/templates/default.nix generates the placeholders manifest entry by using the name of the secret in the
sops.secretsattrset. sops-install-secrets looked up the placeholder using the secret name and resolved to the wrong secret when a secret was renamed.This renames the entry in the manifest from
placeholderBySecretNametoplaceholderBySecretKeyand changes the lookup to use the key instead of the name.This fixes my issue in #688 but results in a new issue that there can be multiple keys.
I think another solution would be to store the secrets in the manifest in an object instead of a list and use the name of the secret in the
sops.secretsattrset as the key.