Skip to content

fix sandbox#325

Merged
figsoda merged 1 commit intoMic92:masterfrom
figsoda:sandbox
Mar 26, 2023
Merged

fix sandbox#325
figsoda merged 1 commit intoMic92:masterfrom
figsoda:sandbox

Conversation

@figsoda
Copy link
Collaborator

@figsoda figsoda commented Mar 26, 2023

closes #324

@figsoda figsoda mentioned this pull request Mar 26, 2023
Closed
@symphorien
Copy link

symphorien commented Mar 26, 2023

Hum I wanted to try this PR but nix-build fails

running install tests
## run black
/nix/store/vy1gljyx0hx57bjnsyj05g3xw1bm2v6m-stdenv-linux/setup: line 1399: black: command not found
error: builder for '/nix/store/qi8p38w9yxl3gcncf2k3m1xa1kpq9qjv-nixpkgs-review.drv' failed with exit code 127;

@figsoda
Copy link
Collaborator Author

figsoda commented Mar 26, 2023

Might be because NixOS/nixpkgs#206742 isn't in 22.11 yet, could you try using nix build instead?

symphorien
symphorien approved these changes Mar 26, 2023
View reviewed changes
Copy link

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes the issue, thanks!

@figsoda figsoda merged commit 30a6655 into Mic92:master Mar 26, 2023
@figsoda figsoda deleted the sandbox branch March 26, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@symphorien symphorien symphorien approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--sandbox flag prevents access to temporary nix file and makes shell fail

2 participants

@figsoda @symphorien