Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions nix_update/version/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,15 @@ def extract_version(version: Version, version_regex: str) -> Version | None:
pattern = re.compile(version_regex)
match = re.match(pattern, version.number)
if match is not None:
group = match.group(1)
if group is not None:
# Filter non-matched groups which come back as None.
groups = [g for g in match.groups() if g]
if len(groups) > 0:
number = ".".join(groups)
return Version(
group,
number,
prerelease=version.prerelease,
rev=version.rev
or (None if version.number == group else version.number),
or (None if version.number == number else version.number),
)
return None

Expand Down
19 changes: 19 additions & 0 deletions tests/test_version_regex_no_rev.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,25 @@ def test_main(helpers: conftest.Helpers) -> None:
assert "net-news-wire: 6.1.5 ->" in commit


def test_groups(helpers: conftest.Helpers) -> None:
with helpers.testpkgs(init_git=True) as path:
main(
[
"--file",
str(path),
"postgresql",
"--version-regex",
"^REL_(\\d+)_(\\d+)(?:_(\\d+))?$",
],
)
version = get_nix_value(path, "postgresql.version")
print(version)
assert version != "17.0"
assert version != "17."
assert version != "17"
assert "17." in version


def get_nix_value(path: Path, key: str) -> str:
return subprocess.run(
[
Expand Down
1 change: 1 addition & 0 deletions tests/testpkgs/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,5 @@
set = pkgs.callPackage ./set.nix { };
let-bound-version = pkgs.callPackage ./let-bound-version.nix { };
subpackage = pkgs.callPackage ./subpackage.nix { };
postgresql = pkgs.callPackage ./postgresql.nix { };
}
13 changes: 13 additions & 0 deletions tests/testpkgs/postgresql.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{ fetchFromGitHub, stdenv }:

stdenv.mkDerivation rec {
pname = "postgresql";
version = "17.0";

src = fetchFromGitHub {
owner = "postgres";
repo = "postgres";
tag = "REL_${builtins.replaceStrings [ "." ] [ "_" ] version}";
sha256 = "sha256-AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=";
};
}