Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DX-3888] Update ruleset #728

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: [DX-3888] Update ruleset #728

wants to merge 2 commits into from
+13 −12

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Jan 22, 2025 •
edited
Loading

Summary

  • bumped DCM to 1.26.2
  • added contains to the list of valid prefixes
  • added prefer-static-method
  • fixed linter issues

Testing steps

None

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review January 22, 2025 15:55
@witwash witwash requested a review from a team as a code owner January 22, 2025 15:55
@witwash
Copy link
Contributor Author

witwash commented Jan 27, 2025

@chaeMil 🥺

@witwash witwash changed the title feat: [DX-3888] Update rules set feat: [DX-3888] Update ruleset Jan 27, 2025
@witwash
Copy link
Contributor Author

witwash commented Jan 29, 2025

Let's wait on it for a bit. DCM author will add an option to ignore private methods from the prefer-static-method rule 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@witwash