Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSG-1097: Update Comet Starter to better support theming #84

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Oct 10, 2023

Updates required to allow the Comet Starter App to utilize USWDS design tokens for customizing styling.

Description

  • Removed USWDS css from index exports
  • Removed Header and Footer components from library in favor of using custom header and footer provided through the app
  • Updated Storybook welcome page with info on the Comet Starter App
  • Removed unneeded icon dependency

Related Issue

N/A

Motivation and Context

  • The current method of bundling of USWDS css as part of the comet package breaks the ability to utilize USWDS design tokens. In order to resolve this, the following is required: 1. Remove css export from index file. 2. Add USWDS styling to the comet starter app through the provided SCSS packages.

How Has This Been Tested?

  • This has been tested by creating a beta version of this branch, then successfully adding to the comet starter app and configuring as needed.

Screenshots (if appropriate):

Screenshot 2023-10-10 at 7 37 51 AM

@jbouder jbouder added enhancement New feature or request refactor Misc changes to project structure or configuration labels Oct 10, 2023
Copy link
Collaborator

@LuisdelaVega LuisdelaVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jbouder jbouder merged commit 3ca9b76 into main Oct 10, 2023
5 checks passed
@jbouder jbouder deleted the CSG-1097 branch October 10, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Misc changes to project structure or configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants