Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React 19 #298

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Upgrade to React 19 #298

merged 7 commits into from
Dec 18, 2024

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Dec 10, 2024

Description

  • Updated all react packages to 19
  • Updated peer dependencies for react 18 and 19
  • Fixed issues and updated for React 19
  • Updated dependabot ignores

Related Issue

  • N/A

Motivation and Context

  • React 19 improvements

How Has This Been Tested?

  • Local Testing

Screenshots (if appropriate):

@jbouder jbouder marked this pull request as ready for review December 18, 2024 03:07
@jbouder jbouder added enhancement New feature or request refactor Misc changes to project structure or configuration dependencies Update to some dependency labels Dec 18, 2024
Copy link
Collaborator

@kildre kildre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dmahen1010
Copy link
Collaborator

dmahen1010 commented Dec 18, 2024

I verified unit tests are working as expected. The packages build, except for comet-cli, where I get

> cd packages/comet-cli && npx tsc

../../node_modules/@types/mdx/types.d.ts:23:38 - error TS2503: Cannot find namespace 'JSX'.

23 type StringComponent = Extract<keyof JSX.IntrinsicElements, ElementType extends never ? string : ElementType>;
                                        ~~~

../../node_modules/@types/mdx/types.d.ts:28:23 - error TS2503: Cannot find namespace 'JSX'.

28 export type Element = JSX.Element;
                         ~~~

../../node_modules/@types/mdx/types.d.ts:47:28 - error TS2503: Cannot find namespace 'JSX'.

47     ? new(props: Props) => JSX.ElementClass
                              ~~~

../../node_modules/@types/mdx/types.d.ts:73:46 - error TS2503: Cannot find namespace 'JSX'.

73         [Key in StringComponent]?: Component<JSX.IntrinsicElements[Key]>;
                                                ~~~


Found 4 errors in the same file, starting at: ../../node_modules/@types/mdx/types.d.ts:23```

@jbouder
Copy link
Collaborator Author

jbouder commented Dec 18, 2024

I verified unit tests are working as expected. The packages build, except for comet-cli, where I get

> cd packages/comet-cli && npx tsc

../../node_modules/@types/mdx/types.d.ts:23:38 - error TS2503: Cannot find namespace 'JSX'.

23 type StringComponent = Extract<keyof JSX.IntrinsicElements, ElementType extends never ? string : ElementType>;
                                        ~~~

../../node_modules/@types/mdx/types.d.ts:28:23 - error TS2503: Cannot find namespace 'JSX'.

28 export type Element = JSX.Element;
                         ~~~

../../node_modules/@types/mdx/types.d.ts:47:28 - error TS2503: Cannot find namespace 'JSX'.

47     ? new(props: Props) => JSX.ElementClass
                              ~~~

../../node_modules/@types/mdx/types.d.ts:73:46 - error TS2503: Cannot find namespace 'JSX'.

73         [Key in StringComponent]?: Component<JSX.IntrinsicElements[Key]>;
                                                ~~~


Found 4 errors in the same file, starting at: ../../node_modules/@types/mdx/types.d.ts:23```

Good catch! I'll take a look

@dmahen1010
Copy link
Collaborator

I verified that the tsconfig updated resolved the comet-cli errors. All packages now build successfully.

@jbouder jbouder merged commit 59828a2 into main Dec 18, 2024
6 checks passed
@jbouder jbouder deleted the react-19 branch December 18, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update to some dependency enhancement New feature or request refactor Misc changes to project structure or configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants