-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
implement prefer silk touch to Auto Tool #5730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
src/main/java/meteordevelopment/meteorclient/systems/modules/player/AutoTool.java
Outdated
Show resolved
Hide resolved
src/main/java/meteordevelopment/meteorclient/systems/modules/player/AutoTool.java
Show resolved
Hide resolved
turns out fortune for ores and crops option doesn't work on crops bcs there's simply no suitable tool for it. a simple bypass would do the trick for #5243 |
this would do the trick |
score += 9000 + (itemStack.get(DataComponentTypes.TOOL).getSpeed(state) * 1000); | ||
|
||
// Prefer hoes slightly for crops when fortune is enabled and the block is a crop. | ||
if (fortuneOre && (state.getBlock() instanceof CropBlock || state.getBlock() instanceof NetherWartBlock) && itemStack.isIn(ItemTags.HOES)) score += 10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's no point to prefer hoes as default when we don't consider using fortune for crops, thats why its req fortuneore option
Type of change
Description
removed silk touch for ender chest option and implemented a whitelist for silk touch. If a suitable tool exists and block is in whitelist, it will always prefer silk touch (unless user doesn't have a silk touch tool, in that case it will choose most suitable tool (or fortune tool if fortuneForOresCrops enabled))
also fixed fortuneForOresCrops wasn't working for crops because there was no suitable tool for it (now they simply bypass tool check if fortuneForOresCrops is on)
Related issues
#5729 #5243
How Has This Been Tested?
https://youtu.be/ECl49wCImMs
Checklist: