Adaptations to new copier version and fix to avoid bash scripts being sourced #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of sourcing them
|
launch jenkins |
|
we could add this barrier https://stackoverflow.com/questions/2683279/how-to-detect-if-a-script-is-being-sourced to the script to prevent the users - in order to make it safer |
clairemerker
changed the title
twicki
suggested changes
Aug 22, 2023
| @@ -19,7 +19,7 @@ jobs: | |||
| - name: Create new project | |||
| run: | | |||
| # Note: Make sure python_version is consistent with python-version hardcoded above | |||
| conda run --name blueprint copier --force --vcs-ref=HEAD python_version=3.9 copy . ./docs/example_project | |||
| conda run --name blueprint copier copy --force --vcs-ref=HEAD . ./docs/example_project | |||
There was a problem hiding this comment.
why is the python version removed here?
If we really want to / need to remove it, adopt the comment above
|
closed in favor of #121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes
tools/setup_miniconda.shscript in sourcing it instead of executing it. This breaks the argument parsing of the script. It relies onOPTINDwhich is not reset when calling the script again, and the script then ignores the arguments. I included a hint in the documentation at two locations.It fixes #117 and ideally also fixes the jenkins plan which is currently failing.
Since the copier commands are not backward compatible, this version of the blueprint now works with the new version. Supporting both adds work...