Repository navigation
fix(w3ds-oidc-bridge): support same-phone sign-in via /deeplink-login - #1177
Merged
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signing in to GitW3 on the same phone as the eID Wallet ended in a 404.
For same-phone logins, the wallet opens
new URL("/deeplink-login", redirect)in the browser, carryingename,session,signatureandappVersionas query parameters. The bridge only had the POST/w3ds/callbackused by the QR flow.completeWalletLogin. It applies the same checks and publishes the same SSE events.GET /deeplink-loginsends the browser straight to the client's redirect URI with the code (303). On failure it shows the error page and never redirects.The route lives at the origin root because the wallet drops any path prefix. On GitW3 the reverse proxy routes
/deeplink-loginto the bridge.Tests: 4 new flow tests: the redirect exchanges for tokens, the SSE event, no redirect on a bad signature, and single use. All 188 pass.
pnpm checkshows the same 29 type errors as the base branch, all in older test code.