Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add createDeferredPromise #164

Merged
merged 5 commits into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ describe('index', () => {
"createBigInt",
"createBytes",
"createDataView",
"createDeferredPromise",
"createHex",
"createModuleLogger",
"createNumber",
Expand Down
1 change: 1 addition & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export * from './logging';
export * from './misc';
export * from './number';
export * from './opaque';
export * from './promise';
export * from './time';
export * from './transaction-types';
export * from './versions';
1 change: 1 addition & 0 deletions src/node.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ describe('node', () => {
"createBigInt",
"createBytes",
"createDataView",
"createDeferredPromise",
"createHex",
"createModuleLogger",
"createNumber",
Expand Down
57 changes: 57 additions & 0 deletions src/promise.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
import { createDeferredPromise } from './promise';

describe('Promise utilities', () => {
describe('createDeferredPromise', () => {
it('creates a deferred promise that resolves when resolve is called', async () => {
const { promise, resolve } = createDeferredPromise();

resolve();

expect(await promise).toBeUndefined();
});

it('creates a deferred promise that returns a value', async () => {
const { promise, resolve } = createDeferredPromise<number>();

resolve(10);

expect(await promise).toBe(10);
});

it('creates a deferred promise that rejects when reject is called', async () => {
const { promise, reject } = createDeferredPromise();
const mockError = new Error('test error');

reject(mockError);

await expect(promise).rejects.toThrow('test error');
});

it('ignores subsequent calls to reject or resolve', async () => {
const { promise, reject, resolve } = createDeferredPromise();
resolve();
await promise;

expect(() => reject(new Error('test error'))).not.toThrow();
expect(() => resolve()).not.toThrow();
});

describe('when suppressUnhandledRejection is set', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried writing a test for when this was false, but there was no way to catch the unhandledRejection event. Apparently in the environment Jest runs tests in, the event always bubbles up to the parent process. Attaching an event handler for that event has no effect here. And there was no easy way to attach an event handler to the parent process, I think it'd require patching Jest or creating a custom test environment.

it('does not trigger an unhandled rejection event when the rejection is unhandled', async () => {
const { reject } = createDeferredPromise({
suppressUnhandledRejection: true,
});
const mockError = new Error('test error');
reject(mockError);

// Wait for unhandled rejection error to be triggered
await new Promise((resolve) => {
setTimeout(resolve, 0);
});

// If the test reaches here, it has succeeded
expect(true).toBe(true);
});
});
});
});
58 changes: 58 additions & 0 deletions src/promise.ts
Gudahtt marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
/**
* A deferred Promise.
*
* A deferred Promise is one that can be resolved or rejected independently of
* the Promise construction.
* @template Result - The result type of the Promise.
*/
export type DeferredPromise<Result = void> = {
/**
* The Promise that has been deferred.
*/
promise: Promise<Result>;
/**
* A function that resolves the Promise.
*/
resolve: (result: Result) => void;
/**
* A function that rejects the Promise.
*/
reject: (error: unknown) => void;
};

/**
* Create a defered Promise.
*
* @param args - The arguments.
* @param args.suppressUnhandledRejection - This option adds an empty error handler
* to the Promise to suppress the UnhandledPromiseRejection error. This can be
* useful if the deferred Promise is sometimes intentionally not used.
* @returns A deferred Promise.
* @template Result - The result type of the Promise.
*/
export function createDeferredPromise<Result = void>({
suppressUnhandledRejection = false,
}: {
suppressUnhandledRejection?: boolean;
} = {}): DeferredPromise<Result> {
let resolve: DeferredPromise<Result>['resolve'];
let reject: DeferredPromise<Result>['reject'];
const promise = new Promise<Result>(
(
innerResolve: DeferredPromise<Result>['resolve'],
innerReject: DeferredPromise<Result>['reject'],
) => {
resolve = innerResolve;
reject = innerReject;
},
);

if (suppressUnhandledRejection) {
promise.catch((_error) => {
// This handler is used to suppress the UnhandledPromiseRejection error
});
}

// @ts-expect-error We know that these are assigned, but TypeScript doesn't
return { promise, resolve, reject };
}