Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PermissionController:revokePermissionForAllSubjects #351

Merged
merged 5 commits into from
Apr 18, 2022
Merged

Use PermissionController:revokePermissionForAllSubjects #351

merged 5 commits into from
Apr 18, 2022

Conversation

FrederikBolding
Copy link
Member

To be merged alongside MetaMask/core#764

@FrederikBolding FrederikBolding force-pushed the fb/use-revokePermissionForAllSubjects branch 2 times, most recently from e480f6b to f15087a Compare April 12, 2022 11:38
@FrederikBolding FrederikBolding force-pushed the fb/use-revokePermissionForAllSubjects branch from 28d91fd to 2703d5b Compare April 17, 2022 22:15
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022 •
edited
Loading

Codecov Report

Merging #351 (2703d5b) into main (38afca9) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   80.49%   80.54%   +0.04%     
==========================================
  Files          60       60              
  Lines        2020     2025       +5     
  Branches      375      375              
==========================================
+ Hits         1626     1631       +5     
  Misses        370      370              
  Partials       24       24
Impacted Files Coverage Δ
packages/controllers/src/snaps/SnapController.ts 89.26% <100.00%> (+0.04%) ⬆️
packages/controllers/src/snaps/utils.ts 87.28% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38afca9...2703d5b. Read the comment docs.

@FrederikBolding FrederikBolding marked this pull request as ready for review April 18, 2022 08:21
@FrederikBolding FrederikBolding requested a review from a team as a code owner April 18, 2022 08:21
hmalik88
hmalik88 approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@hmalik88 hmalik88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrederikBolding FrederikBolding merged commit 7014acb into main Apr 18, 2022
@FrederikBolding FrederikBolding deleted the fb/use-revokePermissionForAllSubjects branch April 18, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmalik88 hmalik88 hmalik88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrederikBolding @codecov-commenter @hmalik88