Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use arrayBuffer for fetching and caching local Snaps #2884

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

FrederikBolding
Copy link
Member

Fixes a problem with fetching local Snaps on mobile. React Native does not support blob well, so we can use arrayBuffer and cache Uint8Array instead.

@FrederikBolding FrederikBolding requested a review from a team as a code owner November 13, 2024 11:08
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (8815d9b) to head (72dca23).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2884      +/-   ##
==========================================
- Coverage   94.49%   94.48%   -0.01%     
==========================================
  Files         486      486              
  Lines       10401    10397       -4     
  Branches     1594     1594              
==========================================
- Hits         9828     9824       -4     
  Misses        573      573              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit 0b19875 into main Nov 13, 2024
166 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-blob-usage branch November 13, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants