perf: Reduce unnecessary JSON validation #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
commented
Oct 21, 2024
| @@ -122,12 +115,6 @@ export function assertSnapOutboundRequest(args: RequestArguments) { | |||
| }, | |||
| }), | |||
| ); | |||
| assertStruct( | |||
There was a problem hiding this comment.
As part of input sanitation we already validate that requests from Snaps are valid JSON, making this unnecessary
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2844 +/- ##
==========================================
- Coverage 94.45% 94.45% -0.01%
==========================================
Files 484 484
Lines 10330 10329 -1
Branches 1574 1574
==========================================
- Hits 9757 9756 -1
Misses 573 573 ☔ View full report in Codecov by Sentry. |
Mrtenz
approved these changes
Oct 21, 2024
FrederikBolding
force-pushed
the
fb/json-validation-perf
branch
from
8d159ab
to
e9c6618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces unnecessary JSON validation when handling JSON-RPC requests to and from Snaps. For large payloads, JSON validation may be expensive, so we should attempt to reduce additional validation where inputs are already validated.