Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snap_getCurrencyRate to SnapMethods #2843

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

GuillaumeRx
Copy link
Contributor

This adds the types for the snap_getCurrencyRate method in snaps-sdk. It was forgotten in #2763

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner October 16, 2024 12:45
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.44%. Comparing base (a916c19) to head (ca5ee46).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2843   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files         484      484           
  Lines       10324    10324           
  Branches     1574     1574           
=======================================
  Hits         9751     9751           
  Misses        573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuillaumeRx GuillaumeRx merged commit 5d91160 into main Oct 16, 2024
166 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/add-type-get-currency-rate branch October 16, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants