Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update preinstalled example to make buttons actually work #2829

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Oct 11, 2024

Previously the preinstalled example didn't have any logic, and since it's set up to hide the header, there was no way to get out of the dialog. I've added some basic logic now, so it has a working cancel button, and a form with a submit button.

@Mrtenz Mrtenz requested a review from a team as a code owner October 11, 2024 10:46
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.45%. Comparing base (8c8dafe) to head (d4dcc11).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2829   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files         484      484           
  Lines       10341    10341           
  Branches     1576     1576           
=======================================
  Hits         9768     9768           
  Misses        573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mrtenz Mrtenz force-pushed the mrtenz/update-preinstalled-example branch from 0d87cc5 to d4dcc11 Compare October 11, 2024 13:20
@Mrtenz Mrtenz merged commit 68761fb into main Oct 11, 2024
166 checks passed
@Mrtenz Mrtenz deleted the mrtenz/update-preinstalled-example branch October 11, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants