feat: Allow updating interface context #2809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2809 +/- ##
=======================================
Coverage 94.43% 94.43%
=======================================
Files 483 483
Lines 10302 10305 +3
Branches 1566 1567 +1
=======================================
+ Hits 9729 9732 +3
Misses 573 573 ☔ View full report in Codecov by Sentry. |
Mrtenz
reviewed
Oct 8, 2024
packages/snaps-controllers/src/interface/SnapInterfaceController.ts
Outdated
Show resolved
Hide resolved
Mrtenz
reviewed
Oct 8, 2024
| @@ -545,6 +545,60 @@ describe('SnapInterfaceController', () => { | |||
| expect(state).toStrictEqual({ foo: { baz: null } }); | |||
| }); | |||
|
|
|||
| it('can update an interface and context', async () => { | |||
There was a problem hiding this comment.
Can you add a test to make sure the old context is used when no new context is provided?
Mrtenz
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows updating the
contextobject in theSnapInterfaceControllerviasnap_updateInterface. This is a non-breaking change ascontextis optional.Closes #2804