Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snaps-rpc-methods): Use BigInt to parse chain ids #2781

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Oct 1, 2024

There are no size limits on Ethereum chain ids, so we should use BigInt to parse them.

@rekmarks rekmarks requested a review from a team as a code owner October 1, 2024 18:01
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.43%. Comparing base (824fd4f) to head (c5d0161).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2781   +/-   ##
=======================================
  Coverage   94.43%   94.43%           
=======================================
  Files         483      483           
  Lines       10297    10297           
  Branches     1568     1568           
=======================================
  Hits         9724     9724           
  Misses        573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rekmarks rekmarks merged commit 8ff9427 into main Oct 1, 2024
165 checks passed
@rekmarks rekmarks deleted the rekm/safe-chainid-parsing branch October 1, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants