Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add href prop to display a link in Address #2760

Closed
wants to merge 4 commits into from

Conversation

GuillaumeRx
Copy link
Contributor

This PR adds a new optional href prop to Address . It will allow an Address component to display a link out next to the address.

Fixes: #2757

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner September 25, 2024 10:40
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.38%. Comparing base (80b6497) to head (dfba87e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2760   +/-   ##
=======================================
  Coverage   94.38%   94.38%           
=======================================
  Files         477      477           
  Lines       10204    10205    +1     
  Branches     1557     1559    +2     
=======================================
+ Hits         9631     9632    +1     
  Misses        573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Jonathansoufer Jonathansoufer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but shouldn't validate if the href input points to a valid URL?

@GuillaumeRx
Copy link
Contributor Author

LGTM, but shouldn't validate if the href input points to a valid URL?

This is done through the validateLink function that checks if the URL is valid and not on the phishing list. We don't need to do any other checks.

@GuillaumeRx GuillaumeRx deleted the gr/add-href-address branch September 25, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External link prop to our address component
2 participants