Rename hideHeader flag to hideSnapBranding #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david0xd
force-pushed
the
dd/rename-hide-header-flag
branch
from
92b0d4e
to
0d496a5
Compare
GuillaumeRx
approved these changes
Sep 12, 2024
Mrtenz
approved these changes
Sep 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2717 +/- ##
=======================================
Coverage 94.35% 94.35%
=======================================
Files 481 481
Lines 10137 10137
Branches 1541 1541
=======================================
Hits 9565 9565
Misses 572 572 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We made a conclusion that there are more things we should hide for preinstalled Snaps, like SnapIcon inside Snap custom footer button or maybe even something else in the future.
So the decision is made to make this flag name more generic.
Flag
hideHeaderis renamed tohideSnapBranding.