Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more customizable input #2699

Merged
merged 9 commits into from
Sep 6, 2024
Merged

Conversation

david0xd
Copy link
Contributor

@david0xd david0xd commented Sep 4, 2024

This PR adds changes to support more customizable input.
The primary target for customization are start and end accessories within the DS Input Component we're using in extension. This PR allows <Box> as the left or right accessory.
Box elements and their children elements are adjacent to the primary Field-compatible child component, just like the support for the <Button> we have from previous implementations.

Related task: https://github.com/MetaMask/MetaMask-planning/issues/3067

Notes:

  • This PR does not introduce breaking changes, since possibility for adding just simple plain button to the Input field is still supported.

@david0xd david0xd self-assigned this Sep 4, 2024
@david0xd david0xd requested a review from a team as a code owner September 4, 2024 14:17
@david0xd david0xd force-pushed the dd/customizable-input branch from 54e1489 to 4ca3e41 Compare September 6, 2024 10:37
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.31%. Comparing base (5ce5b1d) to head (011016f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2699   +/-   ##
=======================================
  Coverage   94.30%   94.31%           
=======================================
  Files         481      481           
  Lines       10051    10055    +4     
  Branches     1521     1521           
=======================================
+ Hits         9479     9483    +4     
  Misses        572      572           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david0xd david0xd merged commit ac9af83 into main Sep 6, 2024
156 checks passed
@david0xd david0xd deleted the dd/customizable-input branch September 6, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants