-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for more customizable input #2699
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Box on both sides
54e1489
to
4ca3e41
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2699 +/- ##
=======================================
Coverage 94.30% 94.31%
=======================================
Files 481 481
Lines 10051 10055 +4
Branches 1521 1521
=======================================
+ Hits 9479 9483 +4
Misses 572 572 ☔ View full report in Codecov by Sentry. |
FrederikBolding
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds changes to support more customizable input.
The primary target for customization are
start
andend
accessories within the DS Input Component we're using in extension. This PR allows<Box>
as the left or right accessory.Box elements and their children elements are adjacent to the primary Field-compatible child component, just like the support for the
<Button>
we have from previous implementations.Related task: https://github.com/MetaMask/MetaMask-planning/issues/3067
Notes: