fix: Allow any element as the child of Container #2698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
previously approved these changes
Sep 4, 2024
|
@metamaskbot update-pr |
Mrtenz
approved these changes
Sep 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2698 +/- ##
==========================================
- Coverage 94.30% 94.30% -0.01%
==========================================
Files 481 481
Lines 10052 10051 -1
Branches 1521 1521
==========================================
- Hits 9480 9479 -1
Misses 572 572 ☔ View full report in Codecov by Sentry. |
FrederikBolding
deleted the
fb/allow-any-element-as-child-of-container
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow any element (that is contained in
BoxChildStruct) to be the child ofContainer.The existing restriction was somewhat pointless since you can use element from
BoxChildStructat the root.