Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tsup with ts-bridge #2682

Merged
merged 19 commits into from
Sep 10, 2024
Merged

Replace tsup with ts-bridge #2682

merged 19 commits into from
Sep 10, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Aug 30, 2024

This replaces tsup with ts-bridge, which fixes several issues we've found in tsup.

Related to MetaMask/metamask-module-template#247, MetaMask/utils#182.

Copy link

socket-security bot commented Aug 30, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ts-bridge/[email protected] None 0 295 kB mrten
npm/@ts-bridge/[email protected] filesystem, unsafe 0 130 kB mrten

View full report↗︎

@Mrtenz Mrtenz force-pushed the mrtenz/ts-bridge branch 4 times, most recently from 892da5d to f7abe82 Compare September 2, 2024 10:10
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.31%. Comparing base (338e790) to head (a55c724).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2682   +/-   ##
=======================================
  Coverage   94.31%   94.31%           
=======================================
  Files         481      481           
  Lines       10056    10056           
  Branches     1521     1521           
=======================================
  Hits         9484     9484           
  Misses        572      572           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mrtenz
Copy link
Member Author

Mrtenz commented Sep 3, 2024

@metamaskbot update-pr

@Mrtenz
Copy link
Member Author

Mrtenz commented Sep 9, 2024

@metamaskbot update-pr

@Mrtenz
Copy link
Member Author

Mrtenz commented Sep 9, 2024

@metamaskbot update-pr

Comment on lines +8 to +9
"module": "ES2020",
"moduleResolution": "Node10"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snaps-sdk has a .ts file which declares *.svg, *.png, etc., but this doesn't work in Node16 or NodeNext module resolution. I've kept snaps-sdk and the image example at Node10 for now, to not introduce any breaking changes.

Copy link
Member Author

@Mrtenz Mrtenz Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this file because there was a folder called types and also a file types.ts, so importing from ./types could refer to either, and caused issues in ts-bridge.

Comment on lines +7 to +8
"module": "ES2020",
"moduleResolution": "Node10"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snaps-sdk has a .ts file which declares *.svg, *.png, etc., but this doesn't work in Node16 or NodeNext module resolution. I've kept snaps-sdk and the image example at Node10 for now, to not introduce any breaking changes.

@Mrtenz Mrtenz marked this pull request as ready for review September 9, 2024 13:50
@Mrtenz Mrtenz requested a review from a team as a code owner September 9, 2024 13:50
@Mrtenz Mrtenz merged commit ab2e835 into main Sep 10, 2024
156 checks passed
@Mrtenz Mrtenz deleted the mrtenz/ts-bridge branch September 10, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants