feat: Allow CAIP-10 addresses in Address
#2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
changed the title
Address
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@metamask/[email protected]) |
FrederikBolding
force-pushed
the
fb/allow-caip10-addresses
branch
from
07bc946
to
1400811
Compare
|
@metamaskbot update-pr |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2680 +/- ##
=======================================
Coverage 94.30% 94.30%
=======================================
Files 481 481
Lines 10040 10040
Branches 1512 1512
=======================================
Hits 9468 9468
Misses 572 572 ☔ View full report in Codecov by Sentry. |
FrederikBolding
force-pushed
the
fb/allow-caip10-addresses
branch
from
c226552
to
70e9d06
Compare
Mrtenz
reviewed
Sep 2, 2024
Mrtenz
reviewed
Sep 2, 2024
Mrtenz
approved these changes
Sep 2, 2024
Mrtenz
pushed a commit
that referenced
this pull request
Sep 2, 2024
Allow CAIP-10 addresses in the `Address` component. This will need a follow-up PR in the extension to support as well. --------- Co-authored-by: MetaMask Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow CAIP-10 addresses in the
Addresscomponent.This will need a follow-up PR in the extension to support as well.