Add stopAllSnaps function to SnapController
#2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
reviewed
Aug 28, 2024
FrederikBolding
changed the title
stopAllRunningSnaps function to SnapControllerstopAllSnaps function to SnapController
|
|
||
| this.messagingSystem.registerActionHandler( | ||
| `${controllerName}:stopAllSnaps`, | ||
| async (...args) => this.stopAllSnaps(...args), |
There was a problem hiding this comment.
We should test this action and the accompanying function
There was a problem hiding this comment.
Done here: 1e50e98
hmalik88
force-pushed
the
hm/add-stop-all-snaps-action
branch
from
b907d3c to
1e50e98
Compare
FrederikBolding
approved these changes
Aug 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2674 +/- ##
=======================================
Coverage 94.29% 94.30%
=======================================
Files 481 481
Lines 10031 10040 +9
Branches 1511 1512 +1
=======================================
+ Hits 9459 9468 +9
Misses 572 572 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2668