Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock wallet_requestSnaps #2661

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Unblock wallet_requestSnaps #2661

merged 5 commits into from
Sep 2, 2024

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Aug 22, 2024

Removes wallet_requestSnaps from the BLOCKED_RPC_METHODS list.

Closes #2611

@hmalik88 hmalik88 requested a review from a team as a code owner August 22, 2024 21:49
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.30%. Comparing base (e400158) to head (16e405f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2661   +/-   ##
=======================================
  Coverage   94.30%   94.30%           
=======================================
  Files         481      481           
  Lines       10040    10040           
  Branches     1512     1512           
=======================================
  Hits         9468     9468           
  Misses        572      572           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding
Copy link
Member

I think we may wanna hold off on merging this until we have the bugs related to this fixed on extension.

@hmalik88 hmalik88 merged commit 1982796 into main Sep 2, 2024
156 checks passed
@hmalik88 hmalik88 deleted the hm/unblock-request-snaps branch September 2, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unblock wallet_requestSnaps
2 participants