feat: Inline WebView bundle #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2528 +/- ##
=======================================
Coverage 93.95% 93.95%
=======================================
Files 456 456
Lines 9568 9568
Branches 1465 1465
=======================================
Hits 8990 8990
Misses 578 578 ☔ View full report in Codecov by Sentry. |
FrederikBolding
force-pushed
the
fb/inline-webview-bundle
branch
from
15c28f1
to
b952a59
Compare
Jonathansoufer
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Jul 19, 2024
## **Description** Replaces the remote WebView with a locally bundled WebView. This WebView still uses a remote iframe for execution, but the initial load will be using all local code. Dependant on MetaMask/snaps#2528 Also moves the `SnapsExecutionWebView` to the App index to have it available even when the application is locked, also prevents issues with breaking the execution environment when locking the app. --------- Co-authored-by: Jonathan Ferreira <[email protected]> Co-authored-by: JSoufer <[email protected]>
devin-ai-integration bot
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Jul 23, 2024
## **Description** Replaces the remote WebView with a locally bundled WebView. This WebView still uses a remote iframe for execution, but the initial load will be using all local code. Dependant on MetaMask/snaps#2528 Also moves the `SnapsExecutionWebView` to the App index to have it available even when the application is locked, also prevents issues with breaking the execution environment when locking the app. --------- Co-authored-by: Jonathan Ferreira <[email protected]> Co-authored-by: JSoufer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline the Snaps execution bundle in the WebView index.html, this will get us closer to running Snaps without a remote execution environment on mobile.