[BREAKING] Add snap_resolveInterface RPC method
#2509
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2509 +/- ##
==========================================
+ Coverage 93.85% 93.89% +0.03%
==========================================
Files 453 454 +1
Lines 9412 9464 +52
Branches 1436 1445 +9
==========================================
+ Hits 8834 8886 +52
Misses 578 578 ☔ View full report in Codecov by Sentry. |
GuillaumeRx
force-pushed
the
gr/resolve-snap-interface
branch
from
b780384
to
04dd758
Compare
GuillaumeRx
force-pushed
the
gr/resolve-snap-interface
branch
3 times, most recently
from
b097787
to
5492553
Compare
GuillaumeRx
changed the title
snap_resolveInterface RPC methodsnap_resolveInterface RPC method
packages/snaps-controllers/src/interface/SnapInterfaceController.test.tsx
Outdated
Show resolved
Hide resolved
packages/snaps-rpc-methods/src/permitted/resolveInterface.test.ts
Outdated
Show resolved
Hide resolved
| @@ -45,33 +46,33 @@ const MAX_FILE_SIZE = 10_000_000; // 10 MB | |||
| */ | |||
| export function getInterfaceResponse( | |||
There was a problem hiding this comment.
Out of scope for this PR, but the new dialog type should be supported here
There was a problem hiding this comment.
Yes I'm going to open a new PR once this one is merged with some support for this new Dialog type in snaps-jest
| import type { PayloadAction } from '@reduxjs/toolkit'; | ||
| import { createAction, createSelector, createSlice } from '@reduxjs/toolkit'; | ||
|
|
||
| import type { ApplicationState } from './store'; | ||
|
|
||
| export type Interface = { | ||
| type: DialogType; | ||
| type: string; |
There was a problem hiding this comment.
@Mrtenz This type is only used internally, right?
There was a problem hiding this comment.
I think these are internal only, I convert them to the dialog type in getInterfaceResponse
| }), | ||
| ).rejects.toThrow( | ||
| 'The "type" property must be one of: alert, confirmation, prompt.', | ||
| 'Invalid params: Expected the value to satisfy a union of `object | object`, but received: [object Object]', |
There was a problem hiding this comment.
We should improve this, but out of scope
|
Please let @Mrtenz leave a review as well if he wants to request any changes for |
GuillaumeRx
force-pushed
the
gr/resolve-snap-interface
branch
from
3536bde
to
c33b9d3
Compare
This PR adds a new non-restricted RPC method that allows a snap to resolve a given user interface bound to a
snap_dialogwith a custom value.resolveInterfacemethod in theSnapInterfaceControllersnap_resolveInterfaceRPC methodsnap_dialogRPC method to set the approval ID to the interface IDsnap_dialognow takes therequestUserApprovalhook which is meant to be bind to theaddAndShowRequestmethod of theApprovalController