-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tooltip
component
#2490
Add Tooltip
component
#2490
Conversation
5bc1514
to
f379561
Compare
f379561
to
f4a6fb1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2490 +/- ##
=======================================
Coverage 94.35% 94.35%
=======================================
Files 440 441 +1
Lines 9070 9076 +6
Branches 1398 1398
=======================================
+ Hits 8558 8564 +6
Misses 512 512 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please address @Mrtenz comments as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments above.
This adds a new component
Tooltip
which can be used to display a tooltip on a text element or an image.This component can wrap any text element (
Text
,Italic
,Bold
,Link
) andImage
and accepts a string or a text element (Text
,Italic
,Bold
,Link
) to be displayed inside it via itsvalue
prop.