fix: use first dropdown option as the default value #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2465 +/- ##
=======================================
Coverage 94.33% 94.34%
=======================================
Files 438 438
Lines 9039 9052 +13
Branches 1384 1391 +7
=======================================
+ Hits 8527 8540 +13
Misses 512 512 ☔ View full report in Codecov by Sentry. |
GuillaumeRx
reviewed
Jun 6, 2024
FrederikBolding
force-pushed
the
fb/fix-default-dropdown-state
branch
from
c0681fb
to
7cd6f4e
Compare
Mrtenz
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem where the default state for a dropdown would be
nulleven though the UI would show option 1 as selected.We fix this by using option 1 as the default state value if nothing is specified.