Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump MetaMask dependencies #2460

Merged
merged 5 commits into from
Jun 7, 2024
Merged

chore: bump MetaMask dependencies #2460

merged 5 commits into from
Jun 7, 2024

Conversation

FrederikBolding
Copy link
Member

Bump several MetaMask dependencies to latest, closing a bunch of dependabot PRs.

@FrederikBolding FrederikBolding requested a review from a team as a code owner June 4, 2024 09:05
@FrederikBolding FrederikBolding marked this pull request as draft June 4, 2024 09:13
Copy link

socket-security bot commented Jun 7, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.34%. Comparing base (4c8ee13) to head (a85116b).

Files Patch % Lines
...ckages/snaps-rpc-methods/src/endowments/keyring.ts 0.00% 1 Missing ⚠️
...naps-rpc-methods/src/endowments/lifecycle-hooks.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2460   +/-   ##
=======================================
  Coverage   94.34%   94.34%           
=======================================
  Files         438      438           
  Lines        9052     9052           
  Branches     1391     1391           
=======================================
  Hits         8540     8540           
  Misses        512      512           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding marked this pull request as ready for review June 7, 2024 13:10
@FrederikBolding
Copy link
Member Author

@SocketSecurity ignore npm/@metamask/[email protected]
@SocketSecurity ignore npm/@metamask/[email protected]

There are MetaMask packages, so we trust them with network access.

@FrederikBolding FrederikBolding merged commit 1bf7e4f into main Jun 7, 2024
152 of 153 checks passed
@FrederikBolding FrederikBolding deleted the fb/bump-mm-deps-2 branch June 7, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants