Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lexer for extraction of markdown links #2261

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

FrederikBolding
Copy link
Member

Changes the implementation of the Markdown link extraction to use the lexer from marked.

For the actual rendering we use https://github.com/syntax-tree/mdast-util-from-markdown but since that is ESM-only I have chosen to use marked in this PR.

@FrederikBolding FrederikBolding requested a review from a team as a code owner March 12, 2024 10:31
Mrtenz
Mrtenz previously approved these changes Mar 12, 2024
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 923 kB tonybrix

View full report↗︎

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (8b461ef) to head (ef322cc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2261      +/-   ##
==========================================
- Coverage   96.61%   96.60%   -0.01%     
==========================================
  Files         337      337              
  Lines        7611     7622      +11     
  Branches     1180     1183       +3     
==========================================
+ Hits         7353     7363      +10     
- Misses        258      259       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit 17fae5a into main Mar 12, 2024
149 of 150 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-markdown-validation branch March 12, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants