Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves timeout handling in the SnapController and in the execution services, it makes a handful of changes:
2
seconds to theping
request, sent to the execution environment after boot. This lets us fail more immediately if the execution environment has loaded but is non-responsive (e.g. if the execution env is down, the iframe loads a Chrome failure page, which still counts as the iframe loading).maxInitTime
as a constructor argument allowing for better configuration of how long Snaps (and the execution environment) has in total to boot before timing out. PreviouslymaxRequestTime
was used for the initialization timeout.